ruby-grape / grape / 22244022029

97%

master: 97%

Build Type

Pull #2657

github

Committed by ericproulx

Commit Message

Instantiate validators at definition time

- Store validator instances in ParamsScope/ContractScope and have
  Endpoint#run_validators read them directly
- Remove ValidatorFactory indirection and eagerly compute validator
  messages/options in constructors
- Freeze validator instances after initialization via Base.new to
  prevent mutation across shared requests (shallow freeze)
- Extract Grape::Util::Translation module shared by Exceptions::Base
  and Validators::Base for I18n translate with fallback locale
- Support Hash messages in translate_message for deferred translation
  with interpolation parameters (e.g. { key: :length, min: 2 })
- Normalize Grape::Exceptions::Validation params handling and refactor
  validator specs to define routes per example group
- Use case/when for message_key extraction in Exceptions::Validation
- Guard LengthValidator against missing constraints and extract option
  validation into private methods to stay within complexity limits
- Store zero-arity procs directly in ValuesValidator (consistent with
  ExceptValuesValidator) and document DB-backed lazy evaluation intent
- Drop test-prof dependency and its spec config

Pull Request Pull Request #2657: Instantiate validators at definition time

Run Details

1061 of 1147 branches covered (92.5%)

Branch coverage included in aggregate %.

186 of 188 new or added lines in 22 files covered. (98.94%)

1 existing line in 1 file now uncovered.

3320 of 3377 relevant lines covered (98.31%)

37644.66 hits per line