PrincetonUniversity / PsyNeuLink / 22219286435

85%

master: 85%

push

github

Component: is_initializing: check parent's is_initializing, not just init status (#3456)

some methods like _update_default_variable are called elsewhere after
initialization of the actual object, and this can cause state side-effects.

avoids incrementing some integrators, as in the duration_cost_fct for
OptimizationControlMechanism in test_modulation_simple or
test_control.py::TestControlSpecification::test_deferred_init

test results are modified; adding extra executions in the None context
prior to running the compositions reproduces the previous results:

test_deferred_init:
`comp.controller.state_input_ports[0].function.execute([1.1]`
`comp.controller.state_input_ports[1].function.execute([2.2]`

test_modulation_simple:
`comp.controller.control_signals[0].function.duration_cost_fct.execute([3]`

see https://github.com/PrincetonUniversity/PsyNeuLink/issues/2721

10334 of 13430 branches covered (76.95%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

35648 of 40928 relevant lines covered (87.1%)

0.87 hits per line