babelfish-for-postgresql / babelfish_extensions / 22185095459

78%

BABEL_6_X_DEV: 78%

push

github

[OSS-ONLY] fix: Replace query parameters with constants in generic plan qual clause (#4530)

Multiple JDBC tests fail when plan_cache_mode is set to force_generic_plan.
Parameters in WHERE clauses should be evaluated once per query and treated
as constants, while parameters in SELECT clauses should be evaluated per row
as dynamic values. However, generic plans do not receive bound parameters
during planning, so Param nodes in qualifiers are not replaced with Const
nodes by eval_const_expressions. This causes parameters to be fetched
dynamically for each row instead of being evaluated once at execution start,
leading to incorrect query results.

To fix this, copy the plannedstmt and replace Param nodes with Const nodes
in plan qualifiers at ExecutorStart before execution.

Task: BABEL-5942

Authored-by: Saurav Samantaray <sauravay@amazon.com>

77 of 103 new or added lines in 1 file covered. (74.76%)

52832 of 68595 relevant lines covered (77.02%)

391630.71 hits per line