zwave-js / zwave-js-ui / 22174740632

19%

push

github

fix(ui): skip GitHub release API call when both features are disabled (#4552)

The `checkChangelog()` function queries GitHub's releases API regardless
of whether `notifyNewVersions` or `disableChangelog` settings are
enabled. When both features are disabled, the API call is unnecessary.

## Changes

- Add early return in `checkChangelog()` when both `notifyNewVersions`
is false and `disableChangelog` is true
- API call now skipped when neither feature requires release data

```javascript
async checkChangelog() {
    const settings = useBaseStore().gateway
    const versions = settings?.versions
    
    // Skip GitHub API call if both features are disabled
    if (!settings.notifyNewVersions && settings?.disableChangelog) {
        return
    }
    
    // get changelog from github latest release
    try {
        const latest = await this.getRelease('zwave-js-ui', 'latest')
        // ... rest of logic unchanged
```

API is still called when either feature needs the release data
(notification display or changelog processing).

> [!WARNING]
>
> <details>
> <summary>Firewall rules blocked me from connecting to one or more
addresses (expand for details)</summary>
>
> #### I tried to connect to the following addresses, but was blocked by
firewall rules:
>
> - `224.0.0.251`
>   - Triggering command: `REDACTED, pid is -1` (packet block)
>
> If you need me to access, download, or install something from one of
these locations, you can either:
>
> - Configure [Actions setup
steps](https://gh.io/copilot/actions-setup-steps) to set up my
environment, which run before the firewall is enabled
> - Add the appropriate URLs or hosts to the custom allowlist in this
repository's [Copilot coding agent
settings](https://github.com/zwave-js/zwave-js-ui/settings/copilot/coding_agent)
(admins only)
>
> </details>

<!-- START COPILOT ORIGINAL PROMPT -->



<details>

<summary>Original prompt</summary>

> 
> ----
> 
> *This section details on the original issue you should r... (continued)

334 of 444 branches covered (75.23%)

Branch coverage included in aggregate %.

4052 of 22295 relevant lines covered (18.17%)

1.13 hits per line