kobotoolbox / kpi / 22148786908

82%

master: 76%

push

github

refactor(editableForm): stop using `allAssets` DEV-1337 (#6713)

### 💭 Notes

Changes here:
- Using orval's `useAssetsRetrieve` instead of
`stores.allAssets.whenLoaded` to fetch asset data
- Kept some weird code to avoid going too far with refactor (e.g.
storing `useAssetsRetrieve` in `setState`)
- Running `launchAppForSurveyContent` when asset data was loaded instead
of relying on `setTimeout`
- Added a safety check inside `launchAppForSurveyContent` to avoid
rendering same HTML multiple times. Also used `refetchOnWindowFocus:
false` to avoid `launchAppForSurveyContent` being run unnecessarily
(code doesn't support getting fresh asset data after it was already
loaded)

### 👀 Preview steps

Things that should still work:
1. Creating new project
   1. Go to #/projects/home
   2. Click "NEW" button and follow through to Form Builder
   3. Add a question
   4. Click "SAVE"
   5. 🟢 Notice it still works
2. Editing existing project
   1. Go to #/projects/home
   2. Open existing project
   3. Click "Edit form" in "Quick Links" (right side of the screen)
   4. 🟢 Notice it opens correctly
   5. While in Form Builder add a question
   6. Click "SAVE"
   7. 🟢 Notice it still works
3. Creating new Library item
1. Same steps as in "Creating new project", but go to
#/library/my-library instead first
4. Editing existing Library item
1. Same steps as "Editing existing project", but go to
#/library/my-library instead first

Found also a bug that I've introduced in this PR that I also fixed in
this PR after review:
1. Have a project with 1 question
2. Edit it in Form Builder
3. Add 2nd question
4. Save form (top right corner) (notice that PATCH call response has 2
questions now)
5. Close form with "x" (top right corner)
6. You end up on /landing route
7. Without navigating elsewhere use "Edit in Form Builder" icon button
8. You end up back in Form Builder
9. Project renders with 1 question (because cached asset)

---------

Co-authored-by: Paulo Amorim <pauloamorimbr... (continued)

7441 of 11473 branches covered (64.86%)

28544 of 34796 relevant lines covered (82.03%)

1.62 hits per line