Unleash / unleash / 22101998964

86%

master: 91%

Build Type

push

github

Committed by web-flow

Commit Message

feat: add ReleasePlanMilestoneStrategyService + plan strategy update (#11319)

Adds a `ReleasePlanMilestoneStrategyService` which is the entry point
for plan strategies updates.

If the plan strategy is active (exists in `feature_strategies`): 
- Milestone service delegates the feature strategy update to
`featureToggleService.updateStrategy() `
- Milestone syncs to `milestone_strategies` row via
`milestoneStrategyStore.upsert() `(which also diffs
`milestone_strategy_segments` join table);
- Feature toggle service is left unchanged.


If the plan strategy is inactive (only exists in
`milestone_strategies`):
- Milestone service updates `milestone_strategies` row +
`milestone_strategy_segments` directly via the store.

### Important files: 


[‎src/lib/features/release-plans/release-plan-milestone-strategy-service.ts‎](https://github.com/Unleash/unleash/pull/11319/changes#diff-5a05d64d965b88a8a7d96635beca68dc4)

[‎src/lib/features/release-plans/release-plan-milestone-strategy-store.ts‎](https://github.com/Unleash/unleash/pull/11319/changes#diff-980ffd62ab4221413eeaf26bd79b3698a)

[‎src/lib/features/feature-toggle/feature-toggle-service.ts‎](https://github.com/Unleash/unleash/pull/11319/changes#diff-4c1b5df5b439c4eb8216282bd3d3edde4)

### Notes
It's a hefty PR, but I felt like there was value in having all this in
one PR to get a full overview of the changes and make sure we are on the
same page about them. If you disagree I can always break out some of the
changes of course (e.g. the changes to
`ReleasePlanMilestoneStrategyStore`). 🙏

There are no tests here, I'll add them in a follow up PR in
unleash-enterprise once we add the new endpoint.

Run Details

1745 of 1961 branches covered (88.99%)

16 of 25 new or added lines in 4 files covered. (64.0%)

1 existing line in 1 file now uncovered.

14547 of 16892 relevant lines covered (86.12%)

896.55 hits per line