Idrinth / habit-evaluator / 22071398672

40%

push

github

Fix Maestro exit code not propagating test failures in CI (#430)

* Fix Maestro exit code not propagating test failures in CI

The Maestro test script used a shell variable pattern that could be
unreliable: the adb broadcast command between the test and the exit had
no error handling, and if it failed under set -e, the script would exit
before reaching the deferred exit. Additionally, the android-maestro-report
job always succeeded (if: always()) regardless of test results, masking
failures for downstream jobs and status checks.

Changes:
- Capture Maestro exit code explicitly via $? instead of a flag variable
- Add || true to adb broadcast so coverage collection cannot mask failures
- Emit a GitHub Actions error annotation when Maestro tests fail
- Add a final step in android-maestro-report that fails the job when
  the upstream android-maestro tests did not succeed

https://claude.ai/code/session_01UXaEqHuUYdoemYTsHv2U56

* Remove redundant Maestro failure check from report job

The failure should surface in the individual android-maestro matrix
jobs, not as a late aggregate in the report job. Failing the report
job would force re-checking all tests instead of showing exactly
which matrix entry broke.

https://claude.ai/code/session_01UXaEqHuUYdoemYTsHv2U56

---------

Co-authored-by: Claude <noreply@anthropic.com>

2782 of 7044 branches covered (39.49%)

Branch coverage included in aggregate %.

9426 of 20295 relevant lines covered (46.44%)

2.24 hits per line