ThePalaceProject / web-patron / 21993024367

77%

push

github

Any book with a revoke URL to be returnable (PP-3646) (#93)

## Description

<!--- Describe your changes -->
A check designating which books can be returned has been removed. We now
allow all items that have a revoke URL from the circulation manager to
be returnable. Previously, this behavior was guarded for certain books.

## Motivation and Context

<!--- Why is this change required? What problem does it solve? -->
Certain books that could be loaned were unable to be returned. This
could cause an issue where a user is only allowed a set number of loans.

As well, the new approach to fulfillment should be that if the
circulation manager provides a book with a link to return the loan, then
the CPW should always allow that to happen.
<!--- If it fixes an open issue, please link to the issue here. -->

[Jira PP-3646](https://ebce-lyrasis.atlassian.net/browse/PP-3646)

## How Has This Been Tested?

<!--- Please describe in detail how you tested your changes. -->
Manually tested with newly added BiblioBoard titles.

Updated tests that stripped revoke urls from acquisition links. Added
new test for a fullfillable book that had an indirect acquisition type,
like one that might be found on a BiblioBoard content item.
<!--- Include details of your testing environment, and the tests you ran
to -->
<!--- see how your change affects other areas of the code, etc. -->

## Checklist:

<!--- Go over all the following points, and put an `x` in all the boxes
that apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->

- [ ] I have updated the documentation accordingly.
- [x] All new and existing tests passed.

57 of 74 branches covered (77.03%)

Branch coverage included in aggregate %.

71 of 92 relevant lines covered (77.17%)

11.84 hits per line