skeema / skeema / 21967837624

92%

push

github

flavor: avoid future conflicts with MySQL 10.x vs MariaDB 10.x

In situations where @@global.version and @@global.version_comment both do not
contain any of "mysql", "mariadb", or "percona", we previously fell back on
logic that assumed major version 10+ is MariaDB, vs 9 or less being MySQL.
However, based on prior statements from Oracle, we expect that MySQL 10.0 may
be released in about 5 months, at which point MySQL and MariaDB versioning
schemes will start to conflict.

This commit adjusts the flavor auto-detection fallback logic to yield an
unknown flavor in ambiguous situations. In such a situation, users must set
the flavor option value manually, as indicated by warnings emitted by all
Skeema commands.

This change may be problematic for OS distributions / package managers which
override the version and version_comment in a way that lacks clear
identification of the server software. In particular, packages from Ubuntu
and Homebrew are both known to do this for MySQL packages (but not MariaDB
packages), meaning that the "unknown flavor" situation may start coming up
with MySQL 10.x packages from these platforms, once those exist.

Later this year, this logic will likely be tweaked further to use alternative
ways of identifying ambiguous server flavors. Please file an issue if this
commit results in "unknown flavor" warnings so that we can gauge the impact.

2 of 2 new or added lines in 1 file covered. (100.0%)

10836 of 11717 relevant lines covered (92.48%)

1.11 hits per line