stacklok / toolhive / 21877090766

62%

Build Type

push

github

Committed by web-flow

Commit Message

Add network/client span attributes and fix span status per OTEL semconv (#3750)

* Add network/client attributes and fix span status per OTEL semconv

Add new additive span attributes:
- network.protocol.version from incoming HTTP request
- client.address and client.port from RemoteAddr
- mcp.session.id from Mcp-Session-Id header
- error.type on 5xx errors

Fix span status to follow OTEL semantic conventions:
- 4xx responses now leave span status Unset (client errors)
- 5xx responses set Error with error.type attribute
- 2xx/3xx remain Ok

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Separate frontend and backend protocol version attributes

Use network.protocol.version for the incoming HTTP request protocol
and mcp.backend.protocol.version for the backend transport protocol,
avoiding a silent overwrite when the two differ (e.g., HTTP/2 client
with SSE/HTTP1.1 backend).

Also add negative test for mcp.session.id when header is absent.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

Run Details

53 of 55 new or added lines in 1 file covered. (96.36%)

38 existing lines in 5 files now uncovered.

42520 of 69216 relevant lines covered (61.43%)

76.84 hits per line