stacklok / toolhive / 21875371706

62%

Build Type

push

github

Committed by web-flow

Commit Message

Rename span attributes to MCP OTEL semantic conventions (#3748)

* Rename span attributes to MCP OTEL semantic conventions

Add new standard OTEL semantic convention attribute names alongside
the existing legacy names. New attributes (http.request.method,
mcp.method.name, gen_ai.tool.name, etc.) are always emitted, while
legacy names are conditionally emitted behind UseLegacyAttributes.

Also updates createSpanName to use "{method} {resourceID}" format
and adds mapTransport helper for network.transport mapping.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Address review findings for OTEL attribute rename PR

- Remove duplicate mcp.resource.uri emission for resources/read
- Rename rpc.system to rpc.system.name, move rpc.system to legacy block
- Capture network.protocol.name and network.protocol.version in SSE path
- Simplify span names to just MCP method (avoid cardinality risk)
- Add network.protocol.version to mapTransport (SSE=1.1, streamable-http=2)
- Fix mockSpan.SetStatus to capture status for test verification
- Delete dead TestHTTPMiddleware_FinalizeSpan_Logic test
- Add tests for mcp.resource.uri conditional logic and protocol version

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Remove mcp.protocol.version attribute for now

Defer mcp.protocol.version to a follow-up once we determine the
correct source (header vs constant vs SDK).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

Run Details

87 of 95 new or added lines in 1 file covered. (91.58%)

9 existing lines in 2 files now uncovered.

42507 of 69173 relevant lines covered (61.45%)

78.05 hits per line