umputun / ralphex / 21804433222

81%

Build Type

push

github

Committed by web-flow

Commit Message

Per phase model selection (#75)

* refactor: make PhaseHolder single source of truth for execution phase

Replace the dual-call pattern (r.log.SetPhase + status.SetPhaseInContext)
with a shared PhaseHolder that all components read from. Remove SetPhase
from Logger interfaces, remove context-based phase passing, and wire
PhaseHolder directly to executor for per-phase model selection.

Also adds per-phase Claude model configuration (claude_model_task,
claude_model_review, claude_model_plan).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* fix: show models info in plan mode startup output

Also extract mergeModelsFrom to fix gocyclo lint warning after merge.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* style: align struct field formatting in Values

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* refactor: move PhaseHolder from processor.Config to Runner field

PhaseHolder is a runtime coordination object, not configuration.
Pass it explicitly via New(cfg, log, holder) and as optional last
arg to NewWithExecutors (nil-defaults), removing ~60 alien
PhaseHolder literals from tests.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* refactor: remove nil-guard for PhaseHolder in NewWithExecutors

A nil holder in production would silently create a disconnected
PhaseHolder, breaking per-phase model selection and dashboard updates.
Removing the guard makes misconfiguration an immediate nil-pointer panic.
All test call sites now pass &status.PhaseHolder{} explicitly.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* A bit codestyle

* style: name inline PhaseHolder in progress tests

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* refactor: move PhaseHolder out of DashboardConfig

PhaseHolder is a runtime coordination object, not configuration.
Pass it as a direct parameter to NewDashboard, consistent with
processor.New, progress.NewLogger, and NewBroadcastLogger.

Co-Authored-By: Claude Opus 4.... (continued)

Run Details

69 of 82 new or added lines in 6 files covered. (84.15%)

2 existing lines in 1 file now uncovered.

4892 of 6057 relevant lines covered (80.77%)

212.8 hits per line