MushroomObserver / mushroom-observer / 21787739322

96%

main: 96%

Build Type

Pull #3824

github

Committed by nimmolo

Commit Message

Use convenience field methods consistently across all form components

Replace verbose `render(field(:name).type(wrapper_options: {...}))` patterns
with convenience methods (`text_field`, `textarea_field`, `select_field`,
`checkbox_field`, `autocompleter_field`, `read_only_field`) across 6 form
components. This eliminates inconsistent rendering patterns that led to
silent bugs and confusing code for contributors to imitate.

## Changes

### ApplicationForm (framework)
- Add `:between`, `:wrap_data` to WRAPPER_OPTIONS constant
- Add `:text` to read_only_field's local wrapper options
- Add `Field#radio` method and new RadioField component
- Update `Field#checkbox` to accept `*options` for multi-value checkboxes
- Update `radio_field` to split wrapper/field options like other helpers

### CheckboxField (bug fix)
- Always render Bootstrap wrapper (`<div class="checkbox"><label>`)
- `wrapper_options: { label: false }` now only suppresses label text,
  not the entire wrapper structure (Bootstrap 3 needs `<label>` for
  styling and click targets regardless of visible text)

### RadioField (new component)
- Bootstrap 3 radio group: `<div class="radio"><label><input> text</label></div>`
- Uses Superform's OptionMapper for collection handling
- Supports `wrap_class` wrapper option

### Form component conversions
- **collection_number_form**: 2 text fields; fixed `data: { autofocus: true }`
  that was in wrapper_options (silently ignored) → moved to field attributes
- **external_link_form**: 1 text field, 1 select; fixed `append:` in
  wrapper_options (never rendered) → converted to `with_append` slot
- **herbarium_record_form**: 1 autocompleter, 2 text, 1 textarea
- **sequence_form**: 2 textarea, 1 select, 1 text; fixed `class:` in
  wrapper_options (silently ignored) → `wrap_class:`
- **name_form**: 2 selects, 1 checkbox, 1 autocompleter, 3 textarea with
  slots, 4 locked fields converted from `field(:x).hidden()` to
  `read_only_field`
- **name_tracker_form**... (continued)

Pull Request Pull Request #3824: Phlex Superform: Use convenience field methods consistently

Run Details

94 of 95 new or added lines in 9 files covered. (98.95%)

1 existing line in 1 file now uncovered.

33453 of 34907 relevant lines covered (95.83%)

689.05 hits per line