Alan-Jowett / CoPilot-For-Consensus / 21734651262

78%

push

github

fix: handle Qdrant 409 Conflict race condition in collection creation (#1129)

* fix: handle Qdrant 409 Conflict race condition in collection creation

When multiple instances start simultaneously, they can race to create the
collection. The first succeeds, but others get 409 Conflict. This change
handles that error gracefully since the collection existing is the desired
state.

Fixes #1127

Signed-off-by: Alan Jowett <alanjo@microsoft.com>

* fix: address PR review comments for Qdrant race condition handling

- Use specific UnexpectedResponse exception type with status_code check
  instead of fragile string matching
- Extract _verify_collection_config() helper and call it after catching
  409 to validate collection configuration matches expected parameters
- Add comprehensive unit tests for race condition handling:
  - test_collection_creation_handles_409_conflict
  - test_collection_creation_409_with_incompatible_config_raises
  - test_collection_creation_non_409_error_propagates

Signed-off-by: Alan Jowett <alanjo@microsoft.com>

---------

Signed-off-by: Alan Jowett <alanjo@microsoft.com>

20 of 24 new or added lines in 1 file covered. (83.33%)

8773 of 11257 relevant lines covered (77.93%)

0.87 hits per line