ovn-kubernetes / libovsdb / 21728327703

50%

main: 50%

Build Type

Pull #458

github

Committed by booxter

Commit Message

client: fix race condition in Echo() function

The Echo() function had a race condition where it would fall through
and access the reply variable after CallWithContext() returned an error
(other than ErrShutdown). This caused a data race between the calling
goroutine reading reply in reflect.DeepEqual() and the RPC readLoop
goroutine potentially still writing to it during JSON unmarshaling.

The fix adds the missing error return, matching the pattern used in
all other RPC call sites (transact, getSchema, listDbs, etc).

Race detector output before fix:
==================
WARNING: DATA RACE
Write at reflect.Value.grow() during json.Unmarshal()
  github.com/cenkalti/rpc2.(*Client).readLoop()

Previous read at:
  github.com/ovn-kubernetes/libovsdb/client.(*ovsdbClient).Echo()
  if !reflect.DeepEqual(args, reply) {  // Line 1095
==================

The race is reliably reproduced by the new TestEchoRace test which
runs concurrent Echo() calls while triggering disconnects/reconnects.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

Pull Request Pull Request #458: client: fix race condition in Echo() function

Run Details

1 of 1 new or added line in 1 file covered. (100.0%)

2 existing lines in 1 file now uncovered.

6444 of 12763 relevant lines covered (50.49%)

174.85 hits per line