ovn-kubernetes / libovsdb / 21727870663
50%
main: 50%

LAST BUILD BRANCH: fix-trafficSeen-race
DEFAULT BRANCH: main
Ran
Jobs 1
Files 73
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 50.345%. Remained the same
21727870663

Pull #458

github

booxter 
client: fix race condition in Echo() function

The Echo() function had a race condition where it would fall through
and access the reply variable after CallWithContext() returned an error
(other than ErrShutdown). This caused a data race between the calling
goroutine reading reply in reflect.DeepEqual() and the RPC readLoop
goroutine potentially still writing to it during JSON unmarshaling.

The fix adds the missing error return, matching the pattern used in
all other RPC call sites (transact, getSchema, listDbs, etc).

Race detector output before fix:
==================
WARNING: DATA RACE
Write at 0x00c000474930 by goroutine 438:
  reflect.Value.grow()
      /nix/store/60z37432vmgkg54krwr1z057bqwp7583-go-1.25.5/share/go/src/reflect/value.go:2677 +0x151
  reflect.Value.Grow()
      /nix/store/60z37432vmgkg54krwr1z057bqwp7583-go-1.25.5/share/go/src/reflect/value.go:2664 +0x7c
  encoding/json.(*decodeState).array()
      /nix/store/60z37432vmgkg54krwr1z057bqwp7583-go-1.25.5/share/go/src/encoding/json/decode.go:552 +0x784
  encoding/json.(*decodeState).value()
      /nix/store/60z37432vmgkg54krwr1z057bqwp7583-go-1.25.5/share/go/src/encoding/json/decode.go:370 +0x10d
  encoding/json.(*decodeState).unmarshal()
      /nix/store/60z37432vmgkg54krwr1z057bqwp7583-go-1.25.5/share/go/src/encoding/json/decode.go:183 +0x284
  encoding/json.Unmarshal()
      /nix/store/60z37432vmgkg54krwr1z057bqwp7583-go-1.25.5/share/go/src/encoding/json/decode.go:113 +0x224
  github.com/cenkalti/rpc2/jsonrpc.(*jsonCodec).ReadResponseBody()
      /home/ihrachyshka/go/pkg/mod/github.com/cenkalti/rpc2@v1.0.4/jsonrpc/jsonrpc.go:174 +0x7b
  github.com/cenkalti/rpc2.(*Client).readResponse()
      /home/ihrachyshka/go/pkg/mod/github.com/cenkalti/rpc2@v1.0.4/client.go:223 +0x395
  github.com/cenkalti/rpc2.(*Client).readLoop()
      /home/ihrachyshka/go/pkg/mod/github.com/cenkalti/rpc2@v1.0.4/client.go:99 +0x2d9
  github.com/cenkalti/rpc2.(*Client).Run()
      /home/ihrachyshka/go/pkg/mod/... (continued)
Pull Request #458: client: fix race condition in Echo() function

6425 of 12762 relevant lines covered (50.34%)

113.26 hits per line

Jobs
ID Job ID Ran Files Coverage
1 21727870663.1 73
50.34
 GitHub Action Run
Source Files on build 21727870663