noironetworks / aci-containers / 11573

63%

master: 63%

Build Type

Pull #1666

travis-pro

Committed by jeffinkottaram

Commit Message

Fix repeated netpol file recreation due to map ordering in CR updates

- Sort map keys in buildHostprotRemoteIpList(), updateNodeIpsHostprotRemoteIpContainer(),
  and updateNodeHostprotRemoteIpContainer() to ensure deterministic ordering of
  HostprotRemoteIpContainer CR specs
- Add DeepEqual checks to skip no-op updates
- Fix early return after CR deletion to prevent attempting update on deleted object
- This prevents unnecessary CR updates that were triggering hostagent to
  repeatedly recreate .netpol files
- Also fixes a bug where after deleting a HostprotRemoteIpContainer CR (when not
  found in nsRemoteIpCont cache), the code continued to attempt updating the
  deleted CR, causing 'UID field not found' errors

(cherry picked from commit dd8ed758b)

Pull Request Pull Request #1666: [mmr-6.1.1] Fix repeated netpol file recreation due to map ordering in CR updates

Run Details

49 of 62 new or added lines in 1 file covered. (79.03%)

7 existing lines in 3 files now uncovered.

13458 of 21420 relevant lines covered (62.83%)

0.72 hits per line