agama-project / agama / 21680932968

75%

Build Type

push

github

Committed by web-flow

Commit Message

service: Do not confuse iSCSI targets with the same name (#3123)

## Problem

An iSCSI target (or node, if you use the `iscsiadm` nomenclature) is
identified by its name and its portal. Since the same underlying system
(name) can be exposed through several network endpoints (portal).

But Agama was using only the name (ignoring the portal) to identify
which nodes need to be connected or disconnected.

## Solution

Use the whole information to match the nodes.

## Testing

Added new unit tests

Run Details

2932 of 5130 branches covered (57.15%)

Branch coverage included in aggregate %.

29 of 29 new or added lines in 2 files covered. (100.0%)

28 existing lines in 1 file now uncovered.

20195 of 26119 relevant lines covered (77.32%)

66.79 hits per line