ThePalaceProject / web-patron / 21674941470

77%

push

github

PP-3296 : embed external web viewers within app (#89)

## Description

<!--- Describe your changes -->
Previously, users were directed away from the web catalog to view web
readers provided by distributors. We will now keep users within the app
by rendering any provided web reader URL within an embedded iframe.
While we cannot control how distributors decide to render their viewers
nor can we control how errors will be rendered, any errors will be
non-blocking and users will have the ability to exit the screen and
return the web catalog.

## Motivation and Context

<!--- Why is this change required? What problem does it solve? -->
This change provides a more integrated experience for users by keeping
them within the app.
<!--- If it fixes an open issue, please link to the issue here. -->

[Jira PP-3296](https://ebce-lyrasis.atlassian.net/browse/PP-3296)

## How Has This Been Tested?

<!--- Please describe in detail how you tested your changes. -->
<!--- Include details of your testing environment, and the tests you ran
to -->
<!--- see how your change affects other areas of the code, etc. -->
Added tests to ensure the loading and loaded states render properly.
Also manually tested loans that successfully and unsuccessfully loaded
within the iframe to see how the app handled those scenarios.

## Checklist:

<!--- Go over all the following points, and put an `x` in all the boxes
that apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->

- [ ] I have updated the documentation accordingly.
- [x] All new and existing tests passed.

57 of 74 branches covered (77.03%)

Branch coverage included in aggregate %.

71 of 92 relevant lines covered (77.17%)

11.84 hits per line