stacklok / toolhive / 21583241792

61%

push

github

fix: add custom YAML unmarshalers for registry metadata types (#3545)

Add custom UnmarshalYAML methods to ImageMetadata and RemoteServerMetadata
to handle flattening of embedded BaseServerMetadata fields.

This is needed because swag v2 doesn't support yaml:",inline" tags for
OpenAPI generation - it drops embedded fields from the schema when the
tag is present. By using custom unmarshalers instead of the yaml inline
tag, we get both:
- Correct OpenAPI 3.x schema generation (all embedded fields present)
- Correct YAML unmarshaling of flat structures (for toolhive-registry)

The technique uses yaml.v3's Node-based unmarshaling to decode the same
YAML node twice: first into the embedded struct, then into the parent
using a type alias to avoid infinite recursion.

Workaround for: https://github.com/swaggo/swag/issues/2140
Fixes: https://github.com/stacklok/toolhive/issues/3544

Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>

0 of 14 new or added lines in 1 file covered. (0.0%)

39760 of 65670 relevant lines covered (60.55%)

75.26 hits per line