stacklok / toolhive / 21477351884

60%

Build Type

push

github

Committed by web-flow

Commit Message

Simplify controller and add E2E tests for status reporting (#3468)

* Simplify controller and add E2E tests for status reporting

Remove duplicate backend discovery from VirtualMCPServer controller,
delegating all backend discovery and health monitoring to the vMCP
runtime via StatusReporter.

Controller simplification:
- Remove discoverBackends() method (~130 lines) from controller
- Backend discovery now handled by vMCP runtime with K8sReporter
- Controller focuses on infrastructure: RBAC, Deployment, Service, ConfigMap
- vMCP runtime handles: backend discovery, health monitoring, status updates

Test cleanup:
- Remove virtualmcpserver_discover_backends_test.go (controller-side tests)
- Remove TestDiscoverBackendsWithExternalAuthConfigIntegration from
  virtualmcpserver_externalauth_test.go
- Keep relevant auth conversion tests

E2E test additions:
- Add virtualmcp_status_reporting_test.go with comprehensive tests

Related-to: #3149

* Fix RBAC permissions for VirtualMCPServer status reporting in all modes

The vMCP runtime's K8sReporter updates VirtualMCPServer status in ALL modes
(discovered and inline), but the controller was only creating RBAC resources
for discovered mode. This caused status reporting to fail in inline mode with
permission errors.

Changes:
  - Remove inline mode skip in ensureRBACResources() - create RBAC in all modes
  - Simplify serviceAccountNameForVmcp() to always use dedicated service account
    (unless custom SA is provided)
  - Update RBAC rules comment to clarify usage in all modes
  - Update test TestVirtualMCPServerEnsureRBACResources_StaticMode to expect
    RBAC resources to be created in inline/static mode

The RBAC rules already include virtualmcpservers/status update permissions.
This change ensures those permissions are granted in all modes, allowing the
vMCP runtime to report backend discovery status, health monitoring, and phase
transitions regardless of the outgoing auth source configuration.

* Fix discove... (continued)

Run Details

213 of 289 new or added lines in 10 files covered. (73.7%)

63 existing lines in 5 files now uncovered.

39212 of 64913 relevant lines covered (60.41%)

76.66 hits per line