stacklok / toolhive / 21476873353

60%

Build Type

push

github

Committed by web-flow

Commit Message

Introduce service layer and improve API/CLI error handling (#3480)

This change consolidates registry configuration logic into a service layer
and improves error handling in both the API and CLI.

Changes:

Service Layer:
- Add RegistryConfigService interface (pkg/config/registry_service.go)
- Consolidates registry configuration operations (SetRegistryFromInput, UnsetRegistry)
- Auto-detects registry type (URL/API/File) and provides user-friendly messages
- Add comprehensive service tests (pkg/config/registry_service_test.go)
- Generate mocks for testing (pkg/config/mocks/mock_registry_service.go)

API Layer (pkg/api/v1/registry.go):
- Map structured errors to proper HTTP status codes:
  - 502 Bad Gateway: Validation errors (invalid JSON, missing servers)
  - 504 Gateway Timeout: Connectivity/timeout errors (unreachable hosts)
- Add isConnectivityError() and isValidationError() helpers
- Refactor updateRegistry() to use RegistryConfigService
- Add timeout integration tests (registry_timeout_test.go)

CLI Layer (cmd/thv/app/config.go):
- Use RegistryConfigService for cleaner code
- Add enhanceRegistryError() for user-friendly error messages
- Provide actionable hints for common failure scenarios
- Map error types to match API status codes (504, 502)

Benefits:
- Single source of truth for registry configuration logic
- Consistent error handling across API and CLI
- Better user experience with actionable error messages
- Easier testing with service abstraction

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

* rename type

* Update E2E tests to reflect new registry error behaviour (#3481)

* Infrastructure improvements and bugfixes for vMCP (#3439)

* Infrastructure improvements and bugfixes for vMCP

- Add OpenTelemetry tracing to capability aggregation
- Add singleflight deduplication for discovery requests
- Add health checker self-check prevention
- Add HTTP client timeout fixes
- Improve E2E test reliability
- Various build and infrastru... (continued)

Run Details

114 of 260 new or added lines in 4 files covered. (43.85%)

8 existing lines in 4 files now uncovered.

39194 of 64817 relevant lines covered (60.47%)

76.52 hits per line