iovisor / ubpf / 21460047714
78%

DEFAULT BRANCH: main
Ran
Jobs 6
Files 130
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 76.609%. Remained the same
21460047714

push

github

web-flow 
Add symbolic label support to uBPF assembler (#739)

* Add label support to uBPF assembler - parser and assembler changes

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Add unit tests for label support

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Fix call local encoding and improve test validation

- Fix call local to use relative offsets (not absolute indices)
- Preserve 'local' marker so src_reg=1 is set correctly
- Restrict label names to start with letter/underscore (not digits)
- Remove unused imports (Reg, MemRef)
- Update tests to validate actual instruction encoding (offsets, src_reg)

Addresses review comments:
- Comment 2738187712: call local now uses relative offsets and sets src_reg=1
- Comment 2738187765: labels cannot start with digits
- Comment 2738187789: tests now verify actual instruction encoding
- Comment 2738187831: removed unused imports

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Fix Python 2.7/3.5 compatibility and improve documentation

- Replace all f-strings with % formatting for Python 2.7/3.5 compatibility
- Add detailed docstring to resolve_labels_in_inst explaining intentional
  variation in return tuple sizes based on BPF instruction operand counts
- All tests pass with Python 2.7/3.5 compatible syntax

Addresses review comments:
- Comment 2738386602: f-strings replaced with % formatting
- Comment 2738386631: documented intentional tuple size variation

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Fix isinstance order and add test for digit rejection

- Fix isinstance check order: check for Label before tuple since Label
  is a namedtuple (subclass of tuple)
- Add test_label_starts_with_digit_error to verify parser rejects labels
  starting with digits
- All 10 label tests passing

Addresses review comments:
- Comment 2738465775: Fixed isinstance order
- Comment 2738465803: Added test... (continued)

6334 of 8268 relevant lines covered (76.61%)

533328.55 hits per line

Jobs
ID Job ID Ran Files Coverage
1 run-Debug-macos-latest-x86_64 - 21460047714.1 84
75.37
 GitHub Action Run
2 run-RelWithDebInfo-macos-latest-x86_64 - 21460047714.2 84
75.24
 GitHub Action Run
3 run-Debug-ubuntu-24.04-arm-arm64 - 21460047714.3 69
57.05
 GitHub Action Run
4 run-RelWithDebInfo-ubuntu-latest-x86_64 - 21460047714.4 68
72.08
 GitHub Action Run
5 run-Debug-ubuntu-latest-x86_64 - 21460047714.5 68
72.11
 GitHub Action Run
6 run-RelWithDebInfo-ubuntu-24.04-arm-arm64 - 21460047714.6 69
57.06
 GitHub Action Run
Source Files on build 21460047714