kobotoolbox / kpi / 21447864952

81%

master: 76%

push

github

fix(projectOwnership): only restart transfers that have been accepted DEV-1643 (#6655)

### 📣 Summary
Ensure that project transfers only begin after the recipient has
accepted the invitation, preventing projects from being moved before the
transfer is authorized.

### Notes
This PR also contains an adjustment to ensure that invitations that are
auto-accepted are marked as accepted as soon as they are created to
avoid getting stuck in "pending" if the task fails.

### 👀 Preview steps

1. ℹ️ have an account (userA) and a project
2. Transfer the project to userB
3. Do NOT click on the link in the email userB received for the transfer
4. Wait for several minutes 
5. 🔴 [on release] Refresh userB's project list and see the project has
been transferred
6. 🔴 [on release] Try to click on the link (logged in as userB) and
receive an error that the invite has expired
7. 🟢 [on pr] Refresh userB's project list and see the project has NOT
been transferred
8. 🟢 [on pr] Try to click on the link (logged in as userB) and
successfully transfer the project

To test org invitations:
1. Have an account with an mmo
2. Have another account with a project
3. Invite userB to the mmo
4. Update `project_ownership.utils.create_invite` to error just outside
of the transaction block (eg by adding `x = 1/0`)
5. Restart the kpi_worker
6. As userB, accept the invite
7. Remove the error line
8. Restart the kpi_worker
9. Notice the transfer is restarted and successfully completes

---------

Co-authored-by: rgraber <becca.graber@kobotoolbox.org>

7191 of 11271 branches covered (63.8%)

7 of 7 new or added lines in 2 files covered. (100.0%)

27773 of 34140 relevant lines covered (81.35%)

1.6 hits per line