zalando / skipper / 21404087623

78%

Build Type

push

github

Committed by web-flow

Commit Message

feat: integrate preprocessors into validation mode (#3845)

While skipper runs in validation mode, it doesn't apply prepocessors
which can result in a valid route being blocked as it have invalid
argument before applying preprocessor.

```
r1: SourceFromLast("application") -> <shunt>;
// After preprocessing
r1: * -> SourceFromLast("1.1.1.1") -> <shunt>;
```

This can be test locally via

```bash
~ ./bin/skipper -edit-route=@"application"@"1.1.1.1"@ -validation-webhook-enabled=true -validation-webhook-address=:9085 -validation-webhook-cert-file="validation.crt" -validation-webhook-key-file="validation.key" -enable-advanced-validation=true -application-log-level=debug -kubernetes

~ curl -i -k -X POST -H "Content-Type: application/json" -d @./dataclients/kubernetes/admission/testdata/rg/rg-with-valid-eskip-predicates.json https://127.0.0.1:9085/routegroups
```

Signed-off-by: Mustafa Abdelrahman <mustafa.abdelrahman@zalando.de>

Run Details

5 of 38 new or added lines in 6 files covered. (13.16%)

6 existing lines in 3 files now uncovered.

24631 of 31445 relevant lines covered (78.33%)

92092.19 hits per line