Ouranosinc / xclim / 21299416273

92%

Build Type

push

github

Committed by web-flow

Commit Message

Remove `keep_attrs` option - follow xarray for preserving attributes (#2312)

<!--Please ensure the PR fulfills the following requirements! -->
<!-- If this is your first PR, make sure to add your details to the
AUTHORS.rst! -->
### Pull Request Checklist:
- [x] This PR addresses an already opened issue (for bug fixes /
features)
    - This PR fixes #2308
- [x] Tests for the changes have been added (for bug fixes / features)
- [x] (If applicable) Documentation has been added / updated (for bug
fixes / features)
- [x] CHANGELOG.rst has been updated (with summary of main changes)
- [x] Link to issue (:issue:`number`) and pull request (:pull:`number`)
has been added

### What kind of change does this PR introduce?
Removes xclim's `keep_attrs` option. Attributes for indicators are now
implicitly controlled by xarray's option.

When option `as_dataset` is True and a dataset is given as input, or
when a DataTree is given as input, the global attributes are managed
explicitly by xclim, but still following xarray's option.

### Does this PR introduce a breaking change?
Yes. An option was removed.

### Other information:
The documentation of the `as_dataset` option has been updated. A line
has been added to the "usage" notebook.

Run Details

3 of 3 new or added lines in 1 file covered. (100.0%)

35 existing lines in 4 files now uncovered.

7924 of 8616 relevant lines covered (91.97%)

6.27 hits per line