agama-project / agama / 21207052685

73%

push

github

service: Honor read_only flag from the product configuration (#3054)

## Problem

The product configuration allows to setup the "/" volume as read-only.
That should result in an immutable system.

But that setting is currently ignored by the Agama storage proposal. The
code was commented out temporarily in order to decide how exactly we
wanted to manage immutable systems... but that conversation didn't
happen and the code has remained commented until today.

See https://bugzilla.suse.com/show_bug.cgi?id=1253616

## Solution

Honor the read-only flag.

Clarify the current status of the flag in the code.

## Testing

Tested manually installing openSUSE MicroOS with a patched installer.

Everything works as expected:

```
$ cat /etc/fstab | head -n1
UUID=xxx-yyy-zzz  /  btrfs  ro=vfs  0  0

$ btrfs property get -ts /
ro=true
```

2746 of 5101 branches covered (53.83%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

20129 of 26236 relevant lines covered (76.72%)

61.38 hits per line