raravena80 / ya / 185

78%

Build Type

push

circleci

Committed by web-flow

Commit Message

feat: Add missing features and improve test coverage (#58)

Add new CLI features including connection timeout configuration, output
formatting options, dry-run mode, host pattern filtering, and progress
indicators. Also improve test coverage from 79.4% to 82.5% for the cmd
package through dependency injection for previously untestable code.

Features added:
- Connection timeout overrides (connect-timeout, command-timeout flags)
- Output format selection (text, json, yaml, table)
- Dry-run mode for previewing operations
- Host pattern matching with include/exclude filters
- Progress indicator option for file transfers

Bug fixes:
- Fix SCP flag binding bug in cmd/scp.go (flags were bound to wrong
  viper keys)

Testing improvements:
- Add dependency injection for os.Exit and fmt.Println to make
  Execute() function testable (0% → 100% coverage)
- Add comprehensive unit tests for new features
- Add tests for formatters (TextFormatter, JSONFormatter)
- Add tests for host pattern matching (matchesPattern, shouldIncludeHost,
  filterHosts)
- Add tests for new option setters

Coverage improvements:
- cmd package: 79.4% → 82.5%
- Execute function: 0% → 100% (previously untestable due to os.Exit)
- common package: 97.6% (maintained)

Signed-off-by: Ricardo Aravena <raravena80@gmail.com>

Run Details

154 of 198 new or added lines in 5 files covered. (77.78%)

52 existing lines in 4 files now uncovered.

512 of 660 relevant lines covered (77.58%)

0.88 hits per line