raravena80 / ya / 183

78%

push

circleci

feat: Add security enhancements and code quality improvements (#57)

Security improvements:
- Add SSH key permission validation with warnings for insecure permissions
- Validate HOME environment variable with fallback to homedir.Dir()
- Add file path sanitization to prevent directory traversal attacks
- Add SCP binary validation (existence and executable check)
- Add large file handling with 1MB limit for SSH key files

Code quality improvements:
- Add context support with SSHSessionWithContext for cancellation
- Add comprehensive godoc comments to exported functions
- Improve error messages with detailed context

Test coverage:
- Add TestValidatePath for path traversal detection
- Add TestValidateSCPPath for SCP binary validation
- Add TestMakeSignerPermissions for permission validation
- Add TestMakeSignerLargeFile for size limit handling

Signed-off-by: Ricardo Aravena <raravena80@gmail.com>

41 of 67 new or added lines in 4 files covered. (61.19%)

416 of 483 relevant lines covered (86.13%)

0.98 hits per line