knex / knex / 21197686116

93%

push

github

Add 'validate' pool options. Resolves #5119. (#5120)

* add 'validate' pool options. resolves #5119.

* check pool.validate in our internal tarn validate function

* Checking for push rights on the PR

* Add pool validate hook, connection lifetime churn, and docs.

* Deleted forgotten "test.txt" (wooops)

* Nicer code

* Better comment

* Extra tests

* Update lib/client.js

Co-authored-by: myndzi <github.com@masquerader.com>

* Update lib/client.js

Co-authored-by: myndzi <github.com@masquerader.com>

* Update lib/client.js

Co-authored-by: myndzi <github.com@masquerader.com>

* Update test/unit/client/pool-config.js

Co-authored-by: myndzi <github.com@masquerader.com>

* Throw an error if expiration persists, change tests accordingly

* Review points addressed

* Fix tests

* Update lib/client.js

Co-authored-by: myndzi <github.com@masquerader.com>

* Update docs/src/guide/index.md

Co-authored-by: myndzi <github.com@masquerader.com>

* Update lib/client.js

Co-authored-by: myndzi <github.com@masquerader.com>

* Fixed documentation

* Use performance.now() for pool connection lifetime calculations

* Add pool lifetime and validate options to types

* Update docs/src/guide/index.md

Co-authored-by: myndzi <github.com@masquerader.com>

* Fixed lint error

* Fix stray extraneous escapes

---------

Co-authored-by: Tony Mobily <tonymobily@gmail.com>
Co-authored-by: myndzi <github.com@masquerader.com>

3678 of 4344 branches covered (84.67%)

Branch coverage included in aggregate %.

141 of 144 new or added lines in 4 files covered. (97.92%)

15147 of 15882 relevant lines covered (95.37%)

2338.25 hits per line