gimli-rs / gimli / 21169341126

89%

Build Type

push

github

Committed by web-flow

Commit Message

read/cfi: minor CIE/FDE parsing optimisation (#866)

When asked to parse a CIE, we would fully parse any CIE or FDE at
the offset, and then discard the result if it was an FDE. Similarly
for parsing an FDE. Optimise this by doing the check of the CIE ID
immediately. In practice this is unlikely to make any difference,
because the entries will always be the expected type if the data is
valid.

Additionally, we had `Error::NotCieId`, `Error::NotCiePointer`, and
`Error::NotFdePointer`, but `Error::NotCiePointer` was not used.
However, `Error::NotCiePointer` is the more logical error for the
situation where `Error::NotFdePointer` was used, so switch to it and
delete `Error::NotFdePointer`.

The git history shows that at some point we already did both of the
above (which is why `NotCiePointer` existed), but they were lost along
the way during refactoring.

Also reorder some function parameters for consistency.

Run Details

67 of 69 new or added lines in 1 file covered. (97.1%)

1 existing line in 1 file now uncovered.

25068 of 28071 relevant lines covered (89.3%)

9573.04 hits per line