zalando / skipper / 21041343213

78%

Build Type

push

github

Committed by web-flow

Commit Message

Make request header bucket sizes configurable (#3829)

This PR makes the request header bucket sizes configurable. 

To test:
`echo 'hello: Path("/hello") -> "https://example.com";' > routes.eskip`

`./bin/skipper -routes-file routes.eskip -support-listener :9911
-metrics-flavour=prometheus -request-size-buckets="1024,$((4
*1024)),$((8 *1024)),$((16 *1024)),$((1024 *1024))"`

Output:
```
# HELP skipper_backend_request_header_bytes Size of a backend request header.
# TYPE skipper_backend_request_header_bytes histogram
skipper_backend_request_header_bytes_bucket{host="_unknownhost_",le="1024"} 1
skipper_backend_request_header_bytes_bucket{host="_unknownhost_",le="4096"} 1
skipper_backend_request_header_bytes_bucket{host="_unknownhost_",le="8192"} 2
skipper_backend_request_header_bytes_bucket{host="_unknownhost_",le="16384"} 2
skipper_backend_request_header_bytes_bucket{host="_unknownhost_",le="1.048576e+06"} 3
skipper_backend_request_header_bytes_bucket{host="_unknownhost_",le="+Inf"} 3
skipper_backend_request_header_bytes_sum{host="_unknownhost_"} 70277
skipper_backend_request_header_bytes_count{host="_unknownhost_"} 3
```

Signed-off-by: greeshma1196 <greeshma.mathew@gmail.com>

Run Details

9 of 13 new or added lines in 3 files covered. (69.23%)

2 existing lines in 1 file now uncovered.

24598 of 31372 relevant lines covered (78.41%)

92417.45 hits per line