rollandf / sriov-network-operator / 21030842510

63%

master: 63%

Build Type

push

github

Committed by rollandf

Commit Message

daemon: fix kernel argument management and logging errors

This commit addresses several issues in the sriov-network-config-daemon
relating to host configuration management and observability.

1. Fix kargs.sh for read-only root filesystems:
   The daemon now uses the host's /tmp directory (via chroot) for temporary
   workspace files. This allows the script to function correctly when the
   container is deployed with 'readOnlyRootFilesystem: true', which previously
   caused 'cp' and 'grep' failures.

2. Improve Ubuntu kargs robustness:
   - Switched from 'grep -P' to 'grep -E' for better compatibility with minimal
     container environments.
   - Added idempotency checks to verify if a kernel argument is already present
     before attempting modification, preventing duplicate entries in GRUB and
     /proc/cmdline.
   - Added support for fallbacks between GRUB_CMDLINE_LINUX and
     GRUB_CMDLINE_LINUX_DEFAULT.
   - Refactored parsing logic to safely handle variable expansions and complex
     quoting in /etc/default/grub.

3. Fix logging serialization bug:
   Updated NodeReconciler to correctly call the Name() method of the main
   plugin when logging errors. Previously, passing the function pointer directly
   caused "json: unsupported type: func() string" errors, masking the actual
   reconciliation failures.

4. Stabilize OS detection and return codes:
   Refactored OS detection in kargs.sh to be more reliable and replaced 'let'
   increments with standard arithmetic expansion to ensure consistent exit codes.

Signed-off-by: Fred Rolland <frolland@nvidia.com>

Run Details

0 of 1 new or added line in 1 file covered. (0.0%)

854 existing lines in 12 files now uncovered.

9388 of 14926 relevant lines covered (62.9%)

0.7 hits per line