safe-global / safe-client-gateway / 20820677306

89%

push

github

feat: add Safe Overview v2 endpoint with Zerion portfolio integration (#2840)

* feat: add Safe Overview v2 endpoint with Zerion portfolio integration

Add a new GET /v2/safes endpoint that uses Zerion's wallet portfolio API
for balance data on chains enabled via FF_ZERION_BALANCES_CHAIN_IDS.

Changes:
- Add ZerionWalletPortfolioApi service to call /v1/wallets/{address}/portfolio
- Add SafesV2Controller and SafesV2Service for the v2 endpoint
- For chains in the feature flag: use Zerion portfolio API (total.positions)
- For other chains: fall back to existing v1 balances logic
- Response structure remains the same as v1 (SafeOverview entity)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

* fix: resolve lint errors in v2 tests

- Remove unused pricesApiKey variable
- Add proper type annotation for body in test assertion

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

* Fix: per chain

* Fix tests: reduce failures from 581 to 236

- Fix TestDbFactory to not close shared mainConnection prematurely
- Update Jest config to exclude integration tests from default run
- Fix test lifecycle issues (afterEach -> afterAll)
- Add 30s timeout for slow controller tests
- Remove duplicate sql.end() call in migration test

Results: 4,884 passing tests (94% success rate)

* fix: remove postgres 'ended' property checks

The postgres library (v3.4.7) no longer has an 'ended' property on the Sql type.
Calling end() on an already-closed connection is safe, so we can remove these checks.

This fixes TypeScript compilation errors in integration tests.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

* Address review comments from vseehausen

- Fix isTestnet parameter documentation to clarify it determines whether data is for testnets or mainnets
- Remove Zerion mention from... (continued)

2944 of 3686 branches covered (79.87%)

Branch coverage included in aggregate %.

113 of 117 new or added lines in 6 files covered. (96.58%)

13890 of 15219 relevant lines covered (91.27%)

842.15 hits per line