skeema / skeema / 20798059973

92%

main: 92%

Build Type

push

github

Committed by evanelias

Commit Message

internal: remove remaining sqlx struct-scanning call sites

This commit refactors the four remaining call sites of sqlx SelectContext
struct-scanning to now use standard library database/sql manual scanning.
This is a continuation of the work in commit 3277076656c. Full removal of the
sqlx dependency will come in a separate commit in the near future.

Two other minor refactors have been made as part of this commit:

* To determine the relative ordering of secondary indexes, SHOW CREATE TABLE
  is now parsed for all flavors. Previously this was only the case in MySQL 8+
  since other flavors could rely on natural information_schema.statistics row
  ordering, as long as no ORDER BY was present. Unifying the approach improves
  consistency and robustness. This parsing is now performed without using
  regular expressions.

* Cross-schema foreign key detection is now handled in Go code, accounting
  properly for lower_case_table_names folding, instead of offloading this to
  the SQL query logic. This may slightly improve introspection performance
  when many FKs are present.

Run Details

154 of 173 new or added lines in 2 files covered. (89.02%)

7 existing lines in 1 file now uncovered.

10837 of 11717 relevant lines covered (92.49%)

1.11 hits per line