skeema / skeema / 20321764706

93%

main: 92%

Build Type

push

github

Committed by evanelias

Commit Message

internal: move more queries away from sqlx struct/slice scanning

This commit refactors a number of Skeema's query code paths to use traditional
Go database/sql (standard library) row scanning, instead of sqlx (external
third-party dependency) methods for scanning directly into a struct or slice.

Although sqlx reduces boilerplate in some cases (especially SHOW commands), it
frequently doesn't help much for many of Skeema's information_schema queries,
which required using special-purpose intermediate structs to handle edge cases
such as NULL values or differences between DB server flavors/versions.

A total of 13 call sites have been converted in this commit. The remaining 4
call sites will be refactored in a subsequent commit in the near future,
followed by one more commit to remove the sqlx dependency.

Two additional minor changes were made in the course of this refactor:

* If two goroutines attempt to simultaneously run the SHOW GRANTS code path on
  the same server, these are now coalesced into a single query.

* We now assume all MySQL 8.0 servers support column default value
  expressions. Technically this isn't true for the first two GA releases from
  mid 2018, MySQL 8.0.11 and 8.0.12. But given 8.0 is reaching Oracle's EOL
  in four months, we can reasonably assume there is no real-world use of such
  early 8.0 point-releases anymore. (Skeema will continue to support 8.0 for
  many years, but we will no longer ensure compatibility with extremely
  ancient point releases.)

Run Details

217 of 258 new or added lines in 3 files covered. (84.11%)

5 existing lines in 3 files now uncovered.

10854 of 11718 relevant lines covered (92.63%)

1.11 hits per line