Alan-Jowett / CoPilot-For-Consensus / 20763756154

76%

Build Type

push

github

Committed by web-flow

Commit Message

Fix source deletion: Cosmos DB document ID resolution and logger signature (#776)

* Initial plan

* Fix logger calls and document store operations for source management

- Fixed all logger.error calls in api.py to use keyword arguments instead of printf-style formatting
- Fixed delete_source() to query for document ID before deleting (Cosmos SDK compatibility)
- Fixed update_source() to query for document ID before updating (Cosmos SDK compatibility)

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Remove xfail markers from source update/delete tests

Tests should now pass with the fixed delete_source() and update_source() implementations

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Remove redundant queries in delete_source and update_source

Removed duplicate get_source() calls that were querying the database unnecessarily before the actual query to get the document ID

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Use explicit None checks for document ID fallback

Changed from 'or' operator to explicit None check to avoid issues with falsy values like empty strings or 0

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Extract document ID lookup into helper method

Created _get_source_doc_id() helper to eliminate code duplication and avoid duplicate dictionary lookups in update_source() and delete_source()

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Simplify ID extraction and fix error handling

- Simplified doc_id extraction to avoid duplicate get() calls
- Added explicit ValueError re-raise to prevent double-wrapping error messages

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Fix ID extraction and remove redundant str() conversions

- Use explicit None checks in ID extraction to preserve falsy but valid IDs (e.g., 0, "")
- Remove redundant str() conv... (continued)

Run Details

17 of 29 new or added lines in 2 files covered. (58.62%)

9 existing lines in 2 files now uncovered.

6261 of 8128 relevant lines covered (77.03%)

0.86 hits per line