Alan-Jowett / CoPilot-For-Consensus / 20728592266

81%

push

github

Defer JWKS fetch to background thread to prevent service startup blocking (#746)

* Initial plan

* Make JWKS fetch non-blocking during middleware initialization

- Add defer_jwks_fetch parameter (default: True) to avoid blocking service startup
- Start background thread to fetch JWKS asynchronously during init
- Add thread-safe lock for JWKS cache updates
- Implement emergency on-demand JWKS fetch if request arrives before background fetch completes
- Wait up to 5 seconds for background thread if JWKS not yet loaded during first request
- Maintains backward compatibility with defer_jwks_fetch=False for synchronous behavior

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Add tests for deferred JWKS fetch and update existing tests

- Add test_middleware_deferred.py with comprehensive tests for deferred loading
- Test non-blocking initialization behavior
- Test emergency on-demand fetch when request arrives before background completes
- Test backward compatibility with defer_jwks_fetch=False
- Test thread-safe cache updates
- Update all existing tests to use defer_jwks_fetch=False for deterministic behavior
- All tests pass successfully

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Fix factory function to pass through defer_jwks_fetch parameter

- Add defer_jwks_fetch parameter to create_jwt_middleware factory function
- Default to True for deferred loading but allow override
- Pass parameter through to JWTMiddleware constructor
- Update docstring to document new parameter
- Addresses code review feedback

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Fix race condition and test issues from code review

- Add thread-safe locking to _fetch_jwks_with_retry for cache updates
- Remove unused imports (jwt, TestClient) from test_middleware_deferred.py
- Fix unused variable warning in test_deferred_jwks_fetch_emergency_on_demand
- Remove incorrect middleware usag... (continued)

30 of 47 new or added lines in 1 file covered. (63.83%)

6243 of 8109 relevant lines covered (76.99%)

0.86 hits per line