orion-ecs / keen-eye / 20652758313

65%

Build Type

push

github

Committed by tyevco

Commit Message

fix: Address code review findings from issue #668

High Priority:
- Add diagnostic logging to SaveFileFormat empty catch block to aid debugging
  of save file validation failures

Medium Priority:
- Create ISaveLoadCapability interface for save/load operations
- Refactor AutoSaveSystem to use ISaveLoadCapability instead of casting to
  concrete World type
- Remove KEEN050 pragma warning suppression and TODO comment
- Add CreateSnapshot and CreateDelta wrapper methods to World

This resolves the two findings from the nightly code review:
1. Empty catch block in SaveFileFormat.cs now logs to Debug output
2. AutoSaveSystem no longer casts IWorld to World directly

Closes #668

Coverage Stats

5084 of 5972 branches covered (85.13%)

Branch coverage included in aggregate %.

26 of 26 new or added lines in 2 files covered. (100.0%)

5 existing lines in 1 file now uncovered.

32805 of 39799 relevant lines covered (82.43%)

1.19 hits per line