MushroomObserver / mushroom-observer / 20627818064

95%

main: 96%

Build Type

Pull #3672

github

Committed by JoeCohen

Commit Message

Fix TypeError when params[:q] is a String in set_project_ivar

Previously, when params[:q] was a saved query ID (String) instead of a
Hash of query parameters, calling params.dig(:q, :projects) raised:
"TypeError: String does not have #dig method"

This occurred when navigating species lists with a saved query parameter,
such as /species_lists/1417?q=1mvpX

Changes:
- Extract query project logic into private extract_query_projects method
- Handle both String (saved query ID) and Hash (inline params) cases
- When params[:q] is a String, load the Query record and extract projects
  from its stored parameters
- Add regression test to prevent future occurrences
- Refactor to resolve RuboCop complexity metrics violations

The fix properly retrieves project associations from saved queries,
allowing species list navigation within project contexts to work
correctly.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

Pull Request Pull Request #3672: Fix TypeError when params[:q] is a String in set_project_ivar

Run Details

1 of 1 new or added line in 1 file covered. (100.0%)

11 existing lines in 4 files now uncovered.

31517 of 33081 relevant lines covered (95.27%)

705.56 hits per line