AnotherRegularDude / ollama-web-search-mcp / 20615329281

100%

push

github

refactor: replace legacy formatter with node-based system (#2)

TL;DR
Refactored the formatter system to use a flexible, tree-based node
structure for improved maintainability and dynamic content handling.

---

## Changes
- **New Node-Based Formatter System**:
- Added `app/cases/node/render_markdown.rb` for rendering node
structures to Markdown.
- Added `app/cases/node/resolve_content.rb` for resolving content text
from node data.
- Added `app/cases/node/truncate_content.rb` for intelligently
truncating content within node structures.
- **New Value Objects for Node Structures**:
- Added `app/value/node.rb` for representing formatted content as a tree
of nodes.
- Added `app/value/root_node.rb` for defining the root of formatting
schemas.
- **Updated Formatter System**:
- Refactored `app/cases/formatter/base.rb` to use the new node-based
system.
- Updated `app/cases/formatter/search_results.rb` and
`app/cases/formatter/fetch_result.rb` to build node-based schemas.
- **MCP Tool Updates**:
- Updated `app/mcp_ext/tool/web_search.rb` and
`app/mcp_ext/tool/web_fetch.rb` to use the new formatter system.
- **Service Layer Updates**:
- Updated `app/cases/search_web.rb` and `app/cases/web_fetch.rb` for
compatibility with the new formatter system.
- **Configuration and Dependency Updates**:
- Updated `Gemfile`, `Gemfile.lock`, and `.ruby-version` for
compatibility.
  - Updated `.rubocop.yml` for code style enforcement.
- **Test Updates**:
- Updated tests for all modified components, including formatters, node
services, MCP tools, and service objects.
  - Added new test files for the node-based formatter system.

---

## Dependencies
- Updated existing dependencies in `Gemfile.lock` to ensure
compatibility with the new formatter system.
- No new external dependencies were added.

---

## Notes
- **Breaking Changes**: This refactor replaces the legacy
component-based formatter system with a tree-based node system. While
the public API for `Cases::SearchWeb` and `C... (continued)

50 of 50 branches covered (100.0%)

Branch coverage included in aggregate %.

203 of 203 new or added lines in 24 files covered. (100.0%)

333 of 333 relevant lines covered (100.0%)

33.8 hits per line