cybertec-postgresql / pgwatch / 20603117210

74%

push

github

[!] support parsing remote logs, closes #1070 (#1072)

Add support for parsing PostgreSQL CSV logs both locally and remotely via
pg_read_file(). The implementation includes robust error handling, privilege
checking, and proper log rotation handling.

Key Changes:
- Implemented remote log parsing using pg_read_file() function
- Added local log parsing support for same-host deployments
- Created LogParser struct to encapsulate parsing logic and state
- Added privilege checking (pg_monitor role and pg_read_file execute rights)
- Implemented proper handling of log rotation, deleted/renamed files
- Set 10MB max chunk size for interval-based reading
- Ensured sink writes occur every interval even without log updates

Testing:
- Added unit tests for remote and local parsing modes
- Added integration tests with PostgreSQL container using CSV logging
- Added tests for error_total and warning_total metrics
- Added privilege checking tests

Refactoring:
- Consolidated logparse package into reaper package
- Split parsing logic into parse_remote.go and parse_local.go
- Replaced direct function calls with LogParser methods

Documentation:
- Updated log parsing documentation
- Added notes about interval adjustment recommendations
- Documented preference for local mode when on same host

303 of 408 new or added lines in 5 files covered. (74.26%)

3861 of 5223 relevant lines covered (73.92%)

0.84 hits per line