Freegle / iznik-server / #2561

88%

push

php-coveralls

Fix flaky EngageTest::testAtRisk - rand(1,0) undefined behavior

When engage_mails table has only 1 variant for an engagement type,
rand(1, count-1) becomes rand(1, 0) which has undefined behavior
in PHP 8. This caused intermittent test failures when the random
10% path was taken but there was only one mail variant available.

Fix: Only attempt random selection when there are 2+ variants.

1 of 1 new or added line in 1 file covered. (100.0%)

26605 of 29732 relevant lines covered (89.48%)

31.74 hits per line