uber / h3 / 20385906724

99%

push

github

(Multi)polygon helper functions (#1104)

* area.c

* adding in more stuff

* merp

* kahan accumulator

* neumaier_add

* notes

* benchmark area

* turn it to 11.

* sadly, no improvement from reusing some trig

* back to original

* simplify

* try adding constants

* format, we must

* Adder docs

* bench

* adder docs

* Settled on Kahan implementation

* Tighten tolerances in testH3CellAreaExhaustive.c due to compensated sum

* 6

* notes

* starting new tests

* tests work

* more tests

* comments

* docstring

* better docstrings

* Adder note

* don't need these imports

* clean a few more imports

* format

* needs constants

* format

* try fuzzer

* .mdx

* docs in h3api.h.in

* rads2

* python plan

* show, don't tell

* benchmark clean up

* never say never again

* ugh, would have been cooler if it compiled the first time

* remove justfile

* lighten the h3api.h.in description, as per usual in that file

* simplify adder initialization

* drop numVerts < 3

* degenerate loop tests

* try _compareArea(NULL, 0, 0.0);

* remove docs

* drop H3_EXPORT

* move geoLoopAreaRads2 out of public API for now

* slim down benchmark

* clear these comments, maybe?

* try adding area.h to APP_SOURCE_FILES

* can't fail if you don't try!

Also, probably do not need to fuzz if no longer in the public API

* minor

* remove justfile

* Adder adder = {};

* (multi)polygon area functions

* degenerate loop note

* destroy sigs

* destroy implementations

* createGlobalMultiPolygon

* testGeoMultiPolygon.c

* try constants

* H3_EXPORT

* rename to createGlobeMultiPolygon

* handle errors. add function docs

* test for geoMultiPolygonAreaRads2

* better test; more coverage

* fix missing brace from github merge

* remove destroyGeoLoop and destroyGeoPolygon from public API

* move global poly function

* remove unnecessary import

* remove justfile

1712 of 1745 branches covered (98.11%)

Branch coverage included in aggregate %.

55 of 55 new or added lines in 2 files covered. (100.0%)

2984 of 3003 relevant lines covered (99.37%)

35930810.33 hits per line