uber / h3 / 20319917210

99%

push

github

Add `geoLoopAreaRads2` function (#1101)

* area.c

* adding in more stuff

* merp

* kahan accumulator

* neumaier_add

* notes

* benchmark area

* turn it to 11.

* sadly, no improvement from reusing some trig

* back to original

* simplify

* try adding constants

* format, we must

* Adder docs

* bench

* adder docs

* Settled on Kahan implementation

* Tighten tolerances in testH3CellAreaExhaustive.c due to compensated sum

* 6

* notes

* starting new tests

* tests work

* more tests

* comments

* docstring

* better docstrings

* Adder note

* don't need these imports

* clean a few more imports

* format

* needs constants

* format

* try fuzzer

* .mdx

* docs in h3api.h.in

* rads2

* python plan

* show, don't tell

* benchmark clean up

* never say never again

* ugh, would have been cooler if it compiled the first time

* remove justfile

* lighten the h3api.h.in description, as per usual in that file

* simplify adder initialization

* drop numVerts < 3

* degenerate loop tests

* try _compareArea(NULL, 0, 0.0);

* remove docs

* drop H3_EXPORT

* move geoLoopAreaRads2 out of public API for now

* slim down benchmark

* clear these comments, maybe?

* try adding area.h to APP_SOURCE_FILES

* can't fail if you don't try!

Also, probably do not need to fuzz if no longer in the public API

* minor

* remove justfile

* Adder adder = {};

* degenerate loop note

* use same public/private underscore convention as iterators.h

* move other cellArea* functions to area.c

* Stitch two 1/4 triangles

* add copyright headers

1697 of 1727 branches covered (98.26%)

Branch coverage included in aggregate %.

41 of 41 new or added lines in 2 files covered. (100.0%)

2929 of 2948 relevant lines covered (99.36%)

36601160.89 hits per line