dtcenter / METplus / 20312034993

92%

main_v6.2: 92%

push

github

Bugfix #2983 develop - StatAnalysis sorted leads and model skip (#3179)

* clean up tests to use common functionality to test wrapper runs and add expected command to compare

* Per #2983, add tests to demonstrate bug

* Per #2983, modified existing tests to ensure that _beg and _end values are computed properly when time values are listed out of order, while preserving the order that the items were specified by the user

* Per #2983, add sort_list=False to calls to get_met_time_list when the order of the items specified by the user should be preserved. Also added sort_list=True, which is the default value, to all calls to get_met_time_list and get_delta_list so it is more clear that the lists returned by those calls are sorted

* Add test to demonstrate bug with multiple grouped models as described in discussion #2982, fix bug by removing whitespace around model values that are formatted with quotation marks and a space after each comma

* Add support for setting column, weight, ss_index_name, and ss_index_vld_thresh in MET config file -- these were set using config overrides in discussion #2982. Also added missing test for hss_ec_value

* cleanup to reduce cognitive complexity and resolve linter complaints

* added and modified tests to increase code coverage

* change return value of function to prevent crash when wrapper is misconfigured -- a new unit test to ensure that the wrapper reports an error uncovered that it crashes instead of gracefully reporting the misconfiguration

* cleanup formatting and update incorrect comments

* add tests to increase code coverage and ensure correct results for other configurations

52 of 53 new or added lines in 1 file covered. (98.11%)

9499 of 10282 relevant lines covered (92.38%)

1.85 hits per line