20220893943
85%

Ran 15 Dec 2025 05:58AM UTC

Jobs 1

Files 61

Run time 1min

Badge

Embed ▾

Committed 12 Dec 2025 04:21PM UTC coverage: 85.114% (+0.2%) from 84.896%

Build # 20220893943

Build Type

push

github

Committed by

web-flow

Commit Message

[CHANGED] MQTT: Permissions to "$MQTT." are now implicit (#7637)

When the server has to create a subscription for a JetStream consumer
(in case of QoS1/2), it would do it with a `$MQTT_sub.` prefix. This
then required users to explicitly add this subject prefix when users had
subscribe permissions.
In more complex setups, there would likely be other permissions to be
granted.

Since the server already checks that a MQTT client is allowed to publish
or subscribe on a given topic/subject based on the user's permissions
set, then the internal need to subscribe to a `$MQTT_sub.xxx` subject
should not be checked. In other words, the server would not create a
subscription on that internal subject if the user is not allowed to
subscribe on "foo" for instance.

So the change in this PR implicitly allows MQTT clients (not regular
NATS core clients) or non client connections (say routes, leaf, etc..)
to pub/sub on any "$MQTT." prefixed subject. Note that the change still
allows "deny" clause to be applied in case the user would want to
explicitly restrict some of the MQTT related subjects to be exchanged.

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>

Run Details

74468 of 87492 relevant lines covered (85.11%)

331102.24 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
2	72.46	0.0%	src/github.com/nats-io/nats-server/server/avl/seqset.go
2	86.18	-0.92%	src/github.com/nats-io/nats-server/server/util.go
3	86.44	0.05%	src/github.com/nats-io/nats-server/server/events.go
4	80.06	0.13%	src/github.com/nats-io/nats-server/server/opts.go
6	87.96	0.19%	src/github.com/nats-io/nats-server/server/consumer.go
6	94.25	0.0%	src/github.com/nats-io/nats-server/server/gateway.go
7	54.4	-0.47%	src/github.com/nats-io/nats-server/server/jetstream_errors_generated.go
12	94.68	-0.15%	src/github.com/nats-io/nats-server/server/client.go
15	83.4	0.16%	src/github.com/nats-io/nats-server/server/filestore.go
18	86.11	-0.26%	src/github.com/nats-io/nats-server/server/stream.go
30	82.79	0.51%	src/github.com/nats-io/nats-server/server/jetstream_cluster.go
33	87.11	-0.63%	src/github.com/nats-io/nats-server/server/raft.go

Jobs

ID	Job ID	Ran	Files	Coverage
1	20220893943.1	15 Dec 2025 05:57AM UTC	61	85.11	GitHub Action Run

nats-io / nats-server / 20220893943
85%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 20220893943

nats-io / nats-server / 20220893943 85%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 20220893943

nats-io / nats-server / 20220893943
85%

README BADGES
x