Alan-Jowett / CoPilot-For-Consensus / 20214131370

78%

push

github

EventPublisher interface now raises exceptions instead of returning bool (#204)

* Implement Phase 2: EventPublisher interface now throws on all failures

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Update tests to match new publisher interface behavior

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Fix exception handling to preserve original exception context

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* fix: update services to propagate publisher exceptions per PR 204

- Remove defensive return value checks from embedding service publish methods
- Update orchestrator service tests to mock exceptions instead of False returns
- Update parsing service tests to mock exceptions instead of False returns
- Update reporting service tests to mock exceptions instead of False returns

All services now properly let EventPublisher exceptions propagate naturally,
aligning with PR 204's goal of having the interface raise exceptions on
failure instead of returning boolean values.

* fix: handle exception in routing key pattern matching integration test

The publisher now raises UnroutableError when publishing to a routing key
with no bound queue (per PR 204 changes). Update test to handle this
exception gracefully.

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>
Co-authored-by: Alan Jowett <alan.jowett@microsoft.com>

5 of 18 new or added lines in 4 files covered. (27.78%)

287 of 453 relevant lines covered (63.36%)

0.63 hits per line