Alan-Jowett / CoPilot-For-Consensus / 20213945075

78%

push

github

Refactor DocumentStore to use exceptions instead of bool return values (#168)

* Initial plan

* Refactor DocumentStore to raise exceptions instead of returning bool/None for errors (Phase 1: Adapter Storage)

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Update embedding service test mock to match new DocumentStore API

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Fix redundant exception handlers in MongoDocumentStore

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Re-raise original exception in parsing main instead of wrapping in ConnectionError

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Address code review feedback: add exc_info=True to logger.error calls, handle specific exceptions, remove unused import

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Fix CI failure: add skip markers for tests requiring optional copilot_schema_validation dependency

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Fix integration tests: import DocumentNotFoundError at module level instead of inline

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* fix(storage): handle InvalidId exception in mongo_document_store

Catch bson.errors.InvalidId when converting document IDs to ObjectId in
get_document, update_document, and delete_document methods. This ensures
proper behavior when invalid ObjectId strings are passed:
- get_document returns None
- update_document raises DocumentNotFoundError
- delete_document raises DocumentNotFoundError

Fixes 3 failing MongoDB integration tests:
- test_update_nonexistent_document
- test_delete_nonexistent_document
- test_invalid_document_id

* fix(services): connect document store in reporting and chunking services

Both reporting and chunking services were creating document stores but
never calling connect() on ... (continued)

26 of 57 new or added lines in 5 files covered. (45.61%)

556 of 784 relevant lines covered (70.92%)

0.71 hits per line