Alan-Jowett / CoPilot-For-Consensus / 20200148669

79%

push

github

Remove implicit defaults from adapter factories (#167)

* Initial plan

* Remove defaults from adapter factories - initial implementation

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Update factory tests and service call sites for explicit configuration

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Update remaining factory tests - enforce explicit configuration

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Fix factory signatures to allow Optional parameters with validation

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Remove getattr defaults from service call sites and factory

- Replace getattr() with explicit hasattr() checks in embedding/main.py
- Replace getattr() with explicit hasattr() checks in summarization/main.py
- Add validation for required config attributes before use
- Remove factory default for mock summarizer latency_ms
- Ensure all required parameters validated with clear error messages

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* fix: update factory tests to require parameters

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>
Co-authored-by: Alan Jowett <alan.jowett@microsoft.com>

80 of 105 new or added lines in 7 files covered. (76.19%)

893 of 1041 relevant lines covered (85.78%)

1.15 hits per line